Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[1.x] feat(upgrade): bump codebase to match sylius v[1.12|1.13|1.14] #23

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

maxperei
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Fixed issue n/a
License MIT

@maxperei maxperei requested a review from Jibbarth December 30, 2024 16:27
@CLAassistant
Copy link

CLAassistant commented Dec 30, 2024

CLA assistant check
All committers have signed the CLA.

@maxperei maxperei force-pushed the feat/migration-sylius-latest-sylius-v1 branch 2 times, most recently from be50e47 to 410a0a8 Compare December 30, 2024 16:46
@maxperei maxperei requested a review from oallain January 23, 2025 11:11
@maxperei maxperei changed the title [1.X] feat(upgrade): bump codebase to match sylius v[1.12|1.13|1.14] [1.x] feat(upgrade): bump codebase to match sylius v[1.12|1.13|1.14] Jan 29, 2025
@maxperei maxperei force-pushed the feat/migration-sylius-latest-sylius-v1 branch from 3388735 to bc0c0d9 Compare January 29, 2025 12:52
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for me 💪🏼

id INT AUTO_INCREMENT NOT NULL,
name VARCHAR(255) NOT NULL,
isEnabled TINYINT(1) NOT NULL,
is_enabled TINYINT(1) NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Not a BC because of, this change is also done in the same tag (1.0.2) and table name too.

@oallain oallain merged commit cf7b5a2 into main Feb 26, 2025
9 checks passed
@oallain oallain deleted the feat/migration-sylius-latest-sylius-v1 branch February 26, 2025 13:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants