Skip to content

Fix atom tags #2

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
May 2, 2023
Merged

Fix atom tags #2

merged 4 commits into from
May 2, 2023

Conversation

lonr
Copy link
Contributor

@lonr lonr commented May 1, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

In atom.js, the categorys of Entries were pushed to the Channel. The logic in rss.js is correct.

This PR fixed that and the corresponding test.

This PR updates the TypeScript version to 5.0 because my PNPM installed version 4.0.* due to the ^4.0.0 specifier in package.json, which did not support the exactOptionalPropertyTypes option in compilerOptions.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 1, 2023
Signed-off-by: Titus <tituswormer@gmail.com>
@wooorm
Copy link
Member

wooorm commented May 2, 2023

There is was no 4.0.* dependency on TS here. It depended on ^4.0.0, which accepts 4.9.0 for example, too.

If pnpm was installing that a 4.0.* version, you need to fix that on your machine, by updating the pnpm caches.

@wooorm wooorm merged commit 8e3fd17 into syntax-tree:main May 2, 2023
@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented May 2, 2023

Thank you! Released in 1.2.3!

@wooorm wooorm added 🐛 type/bug This is a problem 💪 phase/solved Post is done labels May 2, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label May 2, 2023
@lonr lonr deleted the fix-atom-tags branch May 2, 2023 11:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

2 participants