Skip to content

Use Slack notification name field instead of channel. #148

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Use Slack notification name field instead of channel. #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c281b88
Use Slack notification name field instead of channel.
Oct 6, 2020
781a88c
Merge branch 'master' into master
tembleking Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdcclient/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ def get_notification_ids(self, channels=None):
found = True
ids.append(ch['id'])
elif c['type'] == 'SLACK':
opt = ch['options']
if 'channel' in opt and opt['channel'] == c['channel']:
found = True
ids.append(ch['id'])
if 'name' in c:
if c['name'] == ch.get('name'):
found = True
ids.append(ch['id'])
elif c['type'] == 'OPSGENIE':
if 'name' in c:
if c['name'] == ch.get('name'):
Expand Down