Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add proxy support to sysdig client stack #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsimp06
Copy link

@tsimp06 tsimp06 commented Mar 16, 2023

These changes will allow the initializer to add a proxy at initialization of the client to add to the request session, for use for all requests in that instantiation.

@tembleking
Copy link
Member

tembleking commented Mar 23, 2023

@tsimp06 Thank you for the submission, just a quick question: did you try to run the SDK with the environment variables HTTP_PROXY and HTTPS_PROXY configured? Maybe this would be enough instead of configuring the proxies as parameters.

@tsimp06
Copy link
Author

tsimp06 commented Mar 23, 2023

@tsimp06 Thank you for the submission, just a quick question: did you try to run the SDK with the environment variables HTTP_PROXY and HTTPS_PROXY configured? Maybe this would be enough instead of configuring the proxies as parameters.

Yes, and while that works, we don't want to use the proxy for ALL requests, as we are using private endpoints for other requests in the same test.

@tsimp06
Copy link
Author

tsimp06 commented Mar 28, 2023

@tembleking please see previous comment.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants