fix(sysflow): fix double call to StartWorkers() function when policies are reloaded #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are reloaded (#1) Ref: EXP-2010 Signed-off-by: Mauro Sardara <msardara@cisco.com>
msardara
changed the title
araujof
pushed a commit
that referenced
this pull request
Jan 15, 2025
… reloaded (#59) Signed-off-by: Mauro Sardara <msardara@cisco.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new policy file is loaded, sysflow rebuilds the policies using the function
createPolicyInterpreter, that creates the policies and at the end calls thepi.StartWorkers(), that is in charge to start the worker processing the records and applying the rules.The issue comes from the fact that the very same function
createPolicyInterpreteris also used when a new modification to the policy files is detected inCheckForPolicyUpdate:createPolicyInterpretercreates new policies and callspi.StartWorkers()CheckForPolicyUpdatesends a notification to p.interChan <- piProcessin policyengine sees this notification and callss.pi.StopWorkers()ands.pi.StartWorkers()StartWorkersgets called twice, whileStopWorkersis called once. This leads to concurrency issue, in particularpi.workerChandpi.wggets replaced twice inStartWorkersleading to inconsistencies in the wg counter.