Add idle timeout support for logreader based sources #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to call an extra virtual method for each I/O event, bundle this information into the handshake call itself and track whether handshake is in progress in the caller. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Instead of implementing timeout support in derived LogProtoClient classes, just do it once in the prepare() wrapper. This patch also renames "timeout" to "idle_timeout" to better reflect its use. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Idle timeout is only considered when we are actually reading from the peer, in case we are suspended because of flow-control, we ignore the idle timeout. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
HofiOne
force-pushed
the
add-idle-timeout-support-for-logreader-based-sources
branch
from
231ae79 to
68d00aa
Compare
|
Build FAILURE |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #355 by @bazsi
Depends on #5170