Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI: Generate Docker image with commit SHA1 #287

Closed
henrybear327 opened this issue Nov 30, 2023 · 2 comments
Closed

CI: Generate Docker image with commit SHA1 #287

henrybear327 opened this issue Nov 30, 2023 · 2 comments
Assignees
@henrybear327

Comments

@henrybear327
Copy link
Collaborator

Currently, the generated docker image is tagged with latest.

Docker Hub doesn't have a storage limit, and we would like to offer users the ability to switch between commits, thus we should append the commit SHA1 to the image tag.
@henrybear327 henrybear327 self-assigned this Nov 30, 2023
henrybear327 added a commit to henrybear327/rv32emu that referenced this issue Jan 4, 2024
@henrybear327
CI: Generate Docker image with commit SHA1 sysprog21#287
d4a0ae8
henrybear327 added a commit to henrybear327/rv32emu that referenced this issue Jan 4, 2024
@henrybear327
CI: Generate Docker image with commit SHA1 sysprog21#287
739408d
henrybear327 added a commit to henrybear327/rv32emu that referenced this issue Jan 5, 2024
@henrybear327
CI: Generate Docker image with commit SHA1
8996c47 
Close sysprog21#287
henrybear327 added a commit to henrybear327/rv32emu that referenced this issue Jan 5, 2024
@henrybear327
CI: Generate Docker image with commit SHA1
7b76552 
Close sysprog21#287
@jserv jserv closed this as completed in f30cea7 Jan 5, 2024
@henrybear327
Copy link
Collaborator Author

Can only verify when there is a PR with code changes (since docker hub images will only be updated when certain directories have files gotten modified)

@henrybear327
Copy link
Collaborator Author

https://hub.docker.com/r/sysprog21/rv32emu/tags

verified

vestata pushed a commit to vestata/rv32emu that referenced this issue Jan 24, 2025
@henrybear327
CI: Generate Docker image with commit SHA1
0c02549 
Close sysprog21#287
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@henrybear327 henrybear327

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henrybear327