Update mini-gdbstub and the corresponding API #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+55
to
+57
| /* FIXME: This is implemented as a simple workaround for reading | ||
| * an invalid address. We may have to do error handling in the | ||
| * mem_read_* function directly. */ |
Check notice
Code scanning / CodeQL
FIXME comment
Thanks for pointing this. Please improve CI pipeline for gdbstub coverage. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that a GDB user will query an access for invalid register or memory address. In such case, GDBstub should respond
E NN(whereNNis an errno) for the error. However, both the original implementations ofmini-gdbstubandrv32emujust simply assume that those operations will always succeed, which may lead to some annoying problems. For example, a segmentation fault happens on the emulator when we request to read a memory chunk that our emulator didn't write before yet. For this reason, this patch updates the librarymini-gdbstuband the implementation ofrv32emuitself to make debug mode experience onrv32emubetter.By the way, it is worth noting that running the command
make gdbstub-testwill have a fail result. But this is not caused by this patch, because it seems to be broken on the main branch for a long time :(. I'll fix this in other patches and maybe we should runmake gdbstub-testin CICD in the future to make sure it always runs correctly.