Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Try to fix rv_histogram behaves weird on build/hello.elf #199

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Try to fix rv_histogram behaves weird on build/hello.elf #199

merged 2 commits into from
Aug 28, 2023

Conversation

gagachang
Copy link
Contributor

@gagachang gagachang commented Aug 28, 2023 •
edited by jserv
Loading

Separate string from .text section.
Therefore rv32emu instruction decoder would not decode the string and get unknown instructions.

Close #191

@gagachang gagachang mentioned this pull request Aug 28, 2023
Closed
@jserv jserv requested a review from qwe661234 August 28, 2023 09:33
jserv
jserv requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append Close #191 at the end of git commit message, so that the latter can be automatically closed once this pull request is merged.

@gagachang
Fix rv_histogram behaves weird on build/hello.elf
830ada7 
The compiler mixes .text and .data section, that is, the string "Hello
World!\n" is mixed into .text section. The rv32emu instruction decoder
can not decode the string. That's why rv_histogram gets unknown
instruction. Fix it by putting the string into .rodata section.

Close sysprog21#191
@gagachang
Update prebuilt hello.elf
f5bb290 
Update prebuilt hello ELF file to fix unknown instruction issue for
rv_histogram.
@gagachang
Copy link
Contributor Author

Append Close #191 at the end of git commit message, so that the latter can be automatically closed once this pull request is merged.

Done. Appended in 830ada7

@jserv jserv merged commit 14c4b58 into sysprog21:master Aug 28, 2023
@jserv
Copy link
Contributor

jserv commented Aug 28, 2023

Thank @gagachang for contributing!

vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
@jserv
Merge pull request sysprog21#199 from gagachang/hist-hello
f457d4f 
Try to fix rv_histogram behaves weird on build/hello.elf
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jserv jserv jserv requested changes

@qwe661234 qwe661234 qwe661234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rv_histogram behaves weird on build/hello.elf
3 participants
@gagachang @jserv @qwe661234