Refactor time retrieval functions #212
Conversation
visitorckw
force-pushed
the
refactor/time-retrieval-functions
branch
from
52300cd to
465948b
Compare
visitorckw
force-pushed
the
refactor/time-retrieval-functions
branch
from
465948b to
7c57a6c
Compare
| tp->tv_sec = tv_sec; | ||
| tp->tv_nsec = tv_msec; | ||
| tp->tv_nsec = tv_usec / 1000; /* Transfer to microseconds */ |
There was a problem hiding this comment.
The statement appears somewhat unusual. When I initially worked on incorporating newlib support, I encountered some confusion regarding the time scale and units. Could you provide clarification regarding the implementation and expectations related to newlib support?
There was a problem hiding this comment.
The reason for this statement is that when I was reviewing commit 686554c, I noticed that Newlib was manipulating time with millisecond resolution, even though clock_gettime expects nanoseconds in the timespec struct. However, I did not investigate this further at the time. Perhaps I can take a closer look to understand the underlying reasons.
There was a problem hiding this comment.
Add TODO/FIXME comments and submit another pull request(s) when you are ready to resolve the newlib issue.
There was a problem hiding this comment.
I believe the comment on line 57 of the code,/* TODO: clarify newlib internals */, is referring to this issue.
There was a problem hiding this comment.
I believe the comment on line 57 of the code,
/* TODO: clarify newlib internals */, is referring to this issue.
Exactly, you can describe more this time.
visitorckw
force-pushed
the
refactor/time-retrieval-functions
branch
from
7c57a6c to
7b035e9
Compare
This commit refactors time retrieval in utils.c by consolidating common logic from rv_gettimeofday and rv_clock_gettime into a new get_time_info helper function. This enhances code clarity, reduces duplication, and improves maintainability.
visitorckw
force-pushed
the
refactor/time-retrieval-functions
branch
from
7b035e9 to
8cee06c
Compare
…val-functions Refactor time retrieval functions
This commit refactors the time retrieval functions in utils.c to reduce code duplication and improve maintainability. The previous rv_gettimeofday and rv_clock_gettime functions contained similar logic, which has now been extracted into a helper function named get_time_info. This not only makes the code more clear and concise but also enhances reusability.
Summary of changes:
This modification does not affect the functionality of rv32emu but improves code readability and maintainability.