Tweak memory allocation size for portability #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
jserv
reviewed
Sep 17, 2023
ChinYikMing
force-pushed
the
pr
branch
2 times, most recently
from
3dcc234 to
b6d6ec7
Compare
jserv
reviewed
Sep 17, 2023
jserv
reviewed
Sep 17, 2023
jserv
reviewed
Sep 17, 2023
jserv
reviewed
Sep 17, 2023
qwe661234
approved these changes
Sep 18, 2023
2 tasks
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Tweak memory allocation size for portability
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From opinion of @qwe661234 at previous discussion, the data memory usage of most test cases would not reach 0xFFFFFFFF. Thus, it is safe for the changing of memory size allocation to 0xFFFFFFFF such that we do not need to check the platform during compilation.
Close #161