-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improves scripts and add docker image #259
Conversation
- Make the scripts fail as soon as an error is encountered - For common.sh, it will now exit with an non-zero error code when the machine or OS is not supported Reference - https://blog.cloudflare.com/pipefail-how-a-missing-shell-option-slowed-cloudflare-down/
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
4528e66
to
b80c506
Compare
The docker container built from the dockerfile will contain all the necessary development tools pre-installed. It will work for both x86 and aarch64 machines, as the toolchain is built from scratch. README is updated to reflect the build and execute instructions used.
b80c506
to
781b978
Compare
Thank @henrybear327 for contributing! |
Improves scripts and add docker image
This commit adds a docker image that provides the pre-configured environment, which is capable of executing the rv32emu tests, to the users. It can also reduce hassles when working on the M1 machines for development.
Figuring out the
dockerfile
actually took longer than expected, and here are the 2 main issues (there are also copious of comments in thedockerfile
):gcc-riscv64-unknown-elf
compiler installed fromapt
will causemake arch-test
to fail with errorunsupported ISA subset 'z'
, thus, we build from scratch using the version [here].(ttps://github.com/sysprog21/rv32emu/blob/master/.ci/riscv-toolchain-install.sh).sail-riscv
source. Interestingly, it's a known issue that the recent commits will fail to compile. But in any case, for this dockerfile, I am using the commit fromsail-riscv
which is around the time that the commit of the reference emulator happened on rv32emu, which has no problem building and completing tests.Reference: