Fix syscall error handling #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of syscall_write lacks proper error handling, potentially returning 0 even when an error occurs. This fix introduces a check for fwrite errors and updates the return value to -1 in case of an error.
The current implementation of syscall_close lacks proper error handling, potentially returning 0 even when an error occurs. This fix introduces a check for fclose errors and updates the return value to -1 in case of an error.
qwe661234
approved these changes
Dec 22, 2023
|
Thank @visitorckw for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
…ndling Fix syscall error handling
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several system call implementations lack proper error handling, potentially returning 0 even when an error occurs. This patch addresses the issue by introducing a proper check to ensure correct return values when errors occur.