Enforce doubly-linked chained block #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we already have block chaining, there is no need for predicted block.
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
requested changes
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
requested changes
Jan 20, 2024
qwe661234
force-pushed
the
link_BB
branch
2 times, most recently
from
d5d07ac to
467660a
Compare
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
jserv
reviewed
Jan 20, 2024
| if (block1 && block1->translatable) | ||
| if (ir->branch_taken && !set_has(set, ir->branch_taken->pc)) { | ||
| block_t *block1 = cache_get(rv->block_cache, ir->branch_taken->pc); | ||
| if (block1->translatable) |
There was a problem hiding this comment.
Shall we check block1 before dereferencing?
There was a problem hiding this comment.
The block1 must be existed because we correctly handle deleted block.
Previously, the chained block was a linear structure where previous block only pointed to the next block. Now, we have introduced additional information, allowing the next block to also reference the previous block. This modification enhance the deletion of replaced block. Close: sysprog21#329
visitorckw
approved these changes
Jan 21, 2024
|
LGTM, the patches indeed addressed the issue, thanks! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Enforce doubly-linked chained block
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the chained block was a linear structure where previous block only pointed to the next block. Now, we have introduced additional information, allowing the next block to also reference the previous block. This modification enhance the deletion of replaced block.
Close: #329