Implement an input event specific system call for SDL #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Aug 5, 2022
jserv
requested changes
Aug 5, 2022
jserv
reviewed
Aug 5, 2022
|
Read How to Write a Git Commit Message carefully and improve the git commit messages. |
jserv
reviewed
Aug 5, 2022
jserv
reviewed
Aug 5, 2022
jserv
reviewed
Aug 5, 2022
jserv
reviewed
Aug 5, 2022
jserv
requested changes
Aug 5, 2022
alanjian85
force-pushed
the
master
branch
2 times, most recently
from
719a566 to
91e5c11
Compare
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
jserv
reviewed
Aug 6, 2022
|
The proposed git commit message:
Instead of "integrates," we can say, "introduces," which practically explains the motivation. |
alanjian85
force-pushed
the
master
branch
2 times, most recently
from
6584874 to
91da769
Compare
jserv
reviewed
Aug 7, 2022
jserv
changed the title
jserv
reviewed
Aug 7, 2022
| uint32_t type; | ||
| union { | ||
| key_event_t key_event; | ||
| union { |
There was a problem hiding this comment.
I am not sure if a union always works as expected. Can you confirm?
jserv
reviewed
Aug 7, 2022
jserv
requested changes
Aug 7, 2022
alanjian85
force-pushed
the
master
branch
3 times, most recently
from
754a64a to
85fcaf5
Compare
jserv
reviewed
Aug 8, 2022
jserv
reviewed
Aug 8, 2022
jserv
reviewed
Aug 8, 2022
jserv
reviewed
Aug 8, 2022
jserv
requested changes
Aug 8, 2022
There was a problem hiding this comment.
Improve the writing of git commit message:
- Fix grammar mistakes.
- Explain why mouse motion and button are considered as different events from a classification perspective.
- Remove the statement " this new system will improve the interactivity of this emulator" since it is obvious.
Everytime a new frame is drawn, all new input events are pushed into the internal event queue, this commit introduces a new system call, poll_event, which attempts to pop events from the internal event queue and returns input specific event information to the user code. Supported event types: Keyboard Event: either a key is pressed or released Mouse motion event: the cursor is moved Mouse button event: either a mouse button is pressed or released Both the mouse motion and the mouse button event have a corresponding field under the "mouse" field in the event structure to store the event information. However, because these two types of event require entirely different fields in the value buffer, and are processed in different ways in the SDL library, they are considered as different events.
|
Thank @alanjian85 for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Implement an input event specific system call for SDL
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a dedicated event system for game demo input,
syscall_poll_eventrequires the user code pass in anevent_tstructure to populate, and it returns a status flag that indicates whether the event queue is not empty. Theevent_tstructure is a simplified version ofSDL_Event, it has atypefield which may contains:KEY_EVENT,MOUSE_MOTION_EVENTandMOUSE_BUTTON_EVENT, these types of event are enough for the current game demo, and every event type has an associated value buffer stored inunion, the user code may check the detail of event by accessing the corresponding value buffer.Resolve #27