Consolidate AMO RVOP coding consistency #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "addr" variable is used to specify the memory address in many I/O operations within RVOP macro, such as the lh and lw instructions. But, most of the AMO instructions do not use it. Thus, the consistency is consolidated by this commit.
jserv
reviewed
May 6, 2024
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 96af57c | Previous: fe40307 | Ratio |
|---|---|---|---|
Dhrystone |
1760.44 Average DMIPS over 10 runs |
1746.22 Average DMIPS over 10 runs |
0.99 |
Coremark |
1506.573 Average iterations/sec over 10 runs |
1511.811 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Thank @ChinYikMing for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
The 'addr' variable is used to specify the memory address in many I/O operations within the RVOP macro, such as the 'lh' and 'lw' instructions. However, most of the AMO (Atomic Memory Operation) instructions did not use it. To maintain consistency, the use of the 'addr' variable has been consolidated.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "addr" variable is used to specify the memory address in many I/O operations within RVOP macro, such as the lh and lw instructions. But, most of the AMO instructions do not use it. Thus, the consistency is consolidated by this commit.