Fix typo #430
Fix typo #430
Conversation
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: d13520a | Previous: 78fc645 | Ratio |
|---|---|---|---|
Dhrystone |
1734.66 Average DMIPS over 10 runs |
1708.62 Average DMIPS over 10 runs |
0.98 |
Coremark |
1503.12 Average iterations/sec over 10 runs |
1495.662 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
src/rv32_template.c
Outdated
| @@ -1861,7 +1861,7 @@ RVOP( | |||
| * immediate, scaledby 4, to the stack pointer, x2, and writes the result to | |||
| * rd'. | |||
| * This instruction is used to generate pointers to stack-allocated variables, | |||
| * and expands to addi rd', x2, nzuimm[9:2]. | |||
| * and expands to addi rd', x2, nzimm[9:2]. | |||
There was a problem hiding this comment.
Quoting from riscv-spec-v2.2 [1]:
C.ADDI4SPN is a CIW-format RV32C/RV64C-only instruction that adds a zero-extended non-zero
immediate, scaled by 4, to the stack pointer, x2, and writes the result to rd'. This instruction is used
to generate pointers to stack-allocated variables, and expands to addi rd', x2, nzuimm[9:2].
So, as far as I can see, there are no errors in the current description?
Link: https://riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf [1]
There was a problem hiding this comment.
I need some time to check.
There was a problem hiding this comment.
Thank you for the reminder, @visitorckw. I'll adjust my git commit. It's great to have you around.
huaxinliao
force-pushed
the
master
branch
2 times, most recently
from
580e323 to
78fc645
Compare
|
I completed the adjustments to the git commit. Thanks all. |
|
Just being picky here. Please wrap the body of your git commit message at a maximum of 72 characters per line, as mentioned in How to Write a Git Commit Message [1]. Link: https://cbea.ms/git-commit/#wrap-72 [1] |
|
I added a red line to my vim configuration for a maximum of 72 characters per line, as shown in the screenshot. |
|
Thank @p96114175 for contributing! |
Replaced "uimplemented" with "unimplemented", and "Substract" with "Subtract" for clarity and consistency.