Fix unexpected "JALR" behavior in JIT #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The register which stores the indirect address needs to be loaded first to avoid being overriden when the operands are same in "JALR", "C.JALR". Fix sysprog21#472
jserv
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 559dffe | Previous: 1924bdf | Ratio |
|---|---|---|---|
Dhrystone |
1593 Average DMIPS over 10 runs |
1585.87 Average DMIPS over 10 runs |
1.00 |
Coremark |
1405.282 Average iterations/sec over 10 runs |
1396.388 Average iterations/sec over 10 runs |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Thank @vacantron for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Fix unexpected "JALR" behavior in JIT
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register which stores the indirect address needs to be loaded first to avoid being overriden when the operands are same in
JALR,C.JALR.