Pass several privilege tests and fix RV32I comment #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Oct 9, 2022
|
I would anticipate the commit being divided into two:
|
Fix the comment for different types of RV32I instructions format like I, R and J-type and so on.
|
The current result of privilege tests: Check ebreak ... OK
Check ecall ... FAIL
Check misalign1-jalr-01 ... OK
Check misalign2-jalr-01 ... OK
Check misalign-beq-01 ... OK
Check misalign-bge-01 ... OK
Check misalign-bgeu-01 ... OK
Check misalign-blt-01 ... OK
Check misalign-bltu-01 ... OK
Check misalign-bne-01 ... OK
Check misalign-jal-01 ... OK
Check misalign-lh-01 ... OK
Check misalign-lhu-01 ... OK
Check misalign-lw-01 ... OK
Check misalign-sh-01 ... OK
Check misalign-sw-01 ... OK |
jserv
requested changes
Oct 10, 2022
Pass serveral privilege instruction and exceptions tests like ebreak, misaligned load word and misaligned store word. Moreover, the privilege instruction ecall doesn't pass the test because it only dispatches the syscall number to corresponding handler. Therefore, it needs to implement the exception handler with control and status registers (CSRs).
|
The privilege instruction |
|
Thank @Risheng1128 for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Pass several privilege tests and fix RV32I comment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following things:
misaligned load word and misaligned store word.
I, R and J-type and so on.
Because the compiler option
rv32gcwill makeebreakbe compiledas
c.ebreakformat, change it torv32g.