Add BuildKey= and CacheKey= settings #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
stuff
branch
2 times, most recently
from
1393b58 to
07b7ab0
Compare
DaanDeMeyer
force-pushed
the
stuff
branch
2 times, most recently
from
e549d1c to
2c696ff
Compare
DaanDeMeyer
force-pushed
the
stuff
branch
6 times, most recently
from
294fe7d to
57fc7bd
Compare
behrmann
reviewed
Feb 14, 2025
DaanDeMeyer
force-pushed
the
stuff
branch
7 times, most recently
from
ad84985 to
f0b308b
Compare
behrmann
approved these changes
Feb 14, 2025
We already depend on 5.12 for mount_setattr(), so let's drop this check for 5.11 now.
Let's stop showing all derived environment variables values in the summary and let's stop passing them to the default tools and initrd images since they'll be derived again there anyway.
Let's give users more control over how many different cache and build subdirectories we maintain by introducing CacheKey= and BuildKey= with support for delayed specifiers.
In mkosi-kernel, I want to add the following: ``` Linux=&b/kernel/arch/x86_64/boot/bzImage ``` So that I can run `mkosi -t none` to rebuild the kernel image and `mkosi qemu` to boot into it. To make this work, let's add support for a delayed specifier to Linux= that expands to the finalized build directory.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give users more control over how many different cache and
build subdirectories we maintain by introducing CacheKey= and
BuildKey= with support for delayed specifiers.