Add short option for initrd kernel version #3543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrmann
approved these changes
Feb 22, 2025
Both styles were used by the existing code: ['--foo=bar'] and ['--foo', 'bar']. Switch to the former exclusively. A single arg like '--foo=bar' is easier to read and/or select&paste in the log output. Also, we avoid explicit str() wrappers in a bunch of places.
--kernel-version is the option that I use the most often. Having a short option would be nice. '-v' would another option for the option, but I think it could be confused with --version.
keszybz
force-pushed
the
initrd-version-short-option
branch
from
799907d to
587b6ac
Compare
|
Updated. I think the first commit makes sense because we already had a mix of both styles and I don't like the inconsistency. I agree that the "compressed" form can be harder to read for some forms of the value argument, but I think this is outweighed by the fact that the resulting invocation command is easier to read (and select&paste if desired). But if there is no agreement on that commit, I can drop it. |
behrmann
reviewed
Feb 26, 2025
| *(["--package-cache-directory", os.fspath(config.package_cache_dir)] if config.package_cache_dir else []), # noqa: E501 | ||
| *(["--local-mirror", str(config.local_mirror)] if config.local_mirror else []), | ||
| "--incremental", str(config.incremental), | ||
| *([f"--compress-output={p}"] if (p := config.compress_output) else []), |
There was a problem hiding this comment.
Suggested change
| *([f"--compress-output={p}"] if (p := config.compress_output) else []), | |
| *([f"--compress-output={c}"] if (c := config.compress_output) else []), |
| *([f"--prepare-script={os.fspath(script)}" for script in config.tools_tree_prepare_scripts]), | ||
| "--output=tools", | ||
| *(["--source-date-epoch", str(config.source_date_epoch)] if config.source_date_epoch is not None else []), # noqa: E501 | ||
| *([f"--source-date-epoch={p}"] if (p := config.source_date_epoch) is not None else []), |
There was a problem hiding this comment.
Suggested change
| *([f"--source-date-epoch={p}"] if (p := config.source_date_epoch) is not None else []), | |
| *([f"--source-date-epoch={e}"] if (e := config.source_date_epoch) is not None else []), |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.