Implement build overlay mounting with mkosi-sandbox #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have Context.rootoptions(), we can switch out how we set up the root mount without having to modify code all over the place. Let's use this to get rid of mount_build_overlay() and instead replace it with setup_build_overlay(), which simply configures a bunch of fields on Context that make rootoptions() set up the root mount as an overlay instead of a bind mount.
behrmann
approved these changes
Feb 26, 2025
| @@ -637,14 +637,14 @@ def chroot_options() -> list[PathString]: | |||
| @contextlib.contextmanager | |||
| def chroot_cmd( | |||
| *, | |||
| root: Path, | |||
| root: Callable[[PathString], list[str]], | |||
There was a problem hiding this comment.
This might trip us up in the future, since the function we pass in here only fits this because we don't use the keyword arguments. In the future this might be a good use for a Protocol.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have Context.rootoptions(), we can switch out how we set
up the root mount without having to modify code all over the place.
Let's use this to get rid of mount_build_overlay() and instead replace
it with setup_build_overlay(), which simply configures a bunch of
fields on Context that make rootoptions() set up the root mount as an
overlay instead of a bind mount.