Meson tweaks #121
Merged
Meson tweaks #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meson complains:
../meson.build:73: WARNING: Consider using the built-in warning_level option instead of using "-Wextra".
meson complains:
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: mesonbuild/meson#9300
Cherry-pick systemd commit ac3eda34[1] ("meson: use better shellscript
argument passing"):
Passing potentially arbitrary data into a shellscript is potentially
very broken if you do not correctly quote it for use. This quoting
must be done as part of the interpretation of the data itself, e.g.
python's shlex.quote; simply formatting it into a string with double
quotes is NOT sufficient.
An alternative is to communicate the data reliably via argv to the
shell process, and allow the shell to internally handle it via
`"$1"`, which is quote-safe and will expand the data from argv as a
single tokenized word.
Also silences the following meson deprecation notice:
NOTICE: Future-deprecated features used:
* 0.55.0: {'ExternalProgram.path'}
[1]: systemd/systemd@ac3eda3
|
LGTM thank you |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.