-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add tertiary phone number #102
Conversation
@jaapjansma fancy reviewing this, as you authored the secondary phone thing? This could also use a test which I haven't had the time adding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I haven't tested.
I'm fairly sure it needs to be "tertiary" instead of "ternary", just so we don't confuse English native speakers. But if you don't want to change it, i'll add a "sic" :)
Let me know if you need/want me to actually test it.
Fix code style
@bjendres There's a unit test for secondary phone which might be easily adjusted oder copied for testing |
I did, but I cannot assess whether this copy tests all the right things. But the tests all pass now. |
... just as #52 did for a secondary phone number, i. e. a
phone3
parameter and configuration for the phone type.