Fix sindresorhus#1129

szmarczak · Apr 1, 2020 · d64298c · d64298c
1 parent 7645711
commit d64298c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/source/core/index.ts b/source/core/index.ts
@@ -1102,6 +1102,8 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 			this.push(null);
 		});
 
+		this.emit('response', response);
+
 		for (const destination of this[kServerResponsesPiped]) {
 			if (destination.headersSent) {
 				continue;
@@ -1119,8 +1121,6 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 
 			destination.statusCode = statusCode;
 		}
-
-		this.emit('response', response);
 	}
 
 	_onRequest(request: ClientRequest): void {

diff --git a/test/stream.ts b/test/stream.ts
@@ -352,6 +352,21 @@ test('errors have body', withServer, async (t, server, got) => {
 	})));
 
 	t.is(error.message, 'snap');
-	console.log(error.response);
 	t.is(error.response?.body, 'yay');
 });
+
+test('pipe can send modified headers', withServer, async (t, server, got) => {
+	server.get('/foobar', (_request, response) => {
+		response.setHeader('foo', 'bar');
+		response.end();
+	});
+
+	server.get('/', (_request, response) => {
+		got.stream('foobar').on('response', response => {
+			response.headers.foo = 'boo';
+		}).pipe(response);
+	});
+
+	const {headers} = await got('');
+	t.is(headers.foo, 'boo');
+});