Skip to content

Commit

Permalink
Remove requirements to disconnect on warnings
Browse files Browse the repository at this point in the history
We generally shouldn't disconnect when sending or receiving warning
messages. Whenever disconnecting after a warning makes sense, it should
be specified in the requirements linked to that specific scenario.

Fixes lightning#1072
  • Loading branch information
t-bast committed May 5, 2023
1 parent 50b2df2 commit 3747ba8
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions 01-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ A sending node:
- MAY set `channel_id` to all zero to indicate all channels.
- when sending `warning`:
- MAY set `channel_id` to all zero if the warning is not related to a specific channel.
- MAY close the connection after sending.
- MAY send an empty `data` field.
- when failure was caused by an invalid signature check:
- SHOULD include the raw, hex-encoded transaction in reply to a `funding_created`, `funding_signed`, `closing_signed`, or `commitment_signed` message.
Expand All @@ -371,8 +370,6 @@ The receiving node:
- MUST fail the channel referred to by `channel_id`, if that channel is with the sending node.
- upon receiving `warning`:
- SHOULD log the message for later diagnosis.
- MAY disconnect.
- MAY reconnect after some delay to retry.
- MAY attempt `shutdown` if permitted at this point.
- if no existing channel is referred to by `channel_id`:
- MUST ignore the message.
Expand Down

0 comments on commit 3747ba8

Please # to comment.