Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typings for newer versions of TypeScript #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Perl99
Copy link

@Perl99 Perl99 commented Feb 14, 2019

Fixes #890

@DVGalarza
Copy link

DVGalarza commented Mar 1, 2019

I merged your PR into my personal fork of sweetalert, and imported the fork as an NPM package, but the parts of my code importing sweetalert trigger this error:

Module not found: Error: Can't resolve 'sweetalert' in 'C:\dev\...

Did you run into something similar?

(Using a standard import: import swal from 'sweetalert';)

@Perl99
Copy link
Author

Perl99 commented Mar 2, 2019

I don't remember having such a problem.

@DVGalarza
Copy link

Okay, it probably has something to do with how I’m importing the repo then. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants