feat: users csv import #1409
Open
feat: users csv import #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
2 times, most recently
from
1e1e33f to
0152fae
Compare
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
0152fae to
d91bb1d
Compare
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
78f3ede to
dd9f733
Compare
jacalata
force-pushed
the
development
branch
from
4584717 to
257cf61
Compare
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
3 times, most recently
from
257485a to
cff39c1
Compare
|
I've been slow on this one because I have a lot of this code in tabcmd and have been trying to validate against that. I'll make some progress on it soon! |
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
2afca74 to
164afe1
Compare
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
d8da103 to
7f9da2c
Compare
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
7f9da2c to
5aa08cc
Compare
@jacalata Any thoughts on this? |
jorwoods
force-pushed
the
jorwoods/users_csv_import
branch
from
5aa08cc to
80a38ff
Compare
|
Checking in on this PR |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to bulk add and bulk remove users. It has the TSC users pass in an
Iterable[UserItem], and creates the csv file formatted as specified by CSV guidelines.The previous version of
create_users_from_fileread a CSV file, and called the add endpoint for each one. This PR deprecates that endpoint in favor of directing users tobulk_add.