Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove star property hack #62

Open
frozenbonito opened this issue Apr 29, 2022 · 1 comment
Open

Remove star property hack #62

frozenbonito opened this issue Apr 29, 2022 · 1 comment

Comments

@frozenbonito
Copy link

tachyons-sass/scss/_clears.scss

Line 21 in 2dce89b

.cf { *zoom: 1; }

The star property hack is not valid CSS, so it breaks modern css parses.
I think it is safe to remove it because only very old browsers (IE 5.5 to 7) support it.

related:
@silverwind
Copy link

#63

silverwind added a commit to silverwind/tachyons-sass that referenced this issue Aug 29, 2022
@silverwind
Remove IE7 CSS hack
221e436 
Remove this [star property hack](https://stackoverflow.com/a/14927670/808699) that was targeting IE 5.5 to 7.

It causes warnings during ESBuild's CSS minification and IE 7 has a
global market share of 0.01% so I think it can be safely dropped.

Fixes: tachyons-css#62
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @frozenbonito