Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Incorrect type inference for ternary operator #66

Closed
Shvandre opened this issue Feb 6, 2025 · 3 comments · Fixed by #141
Closed

Incorrect type inference for ternary operator #66

Shvandre opened this issue Feb 6, 2025 · 3 comments · Fixed by #141
Assignees
@i582
Labels
bug Something isn't working or doesn't seem right lsp: inlayHint `textDocument/` Inlay Hint Request

Comments

@Shvandre
Copy link

Shvandre commented Feb 6, 2025

Image

Correct type would be "Cell?"
@Shvandre Shvandre added the bug Something isn't working or doesn't seem right label Feb 6, 2025
@i582 i582 changed the title Incorrect type inheritance for ternary conditions Incorrect type inference for ternary operator Feb 6, 2025
@novusnota novusnota added the lsp: inlayHint `textDocument/` Inlay Hint Request label Feb 6, 2025
@i582 i582 self-assigned this Feb 7, 2025
i582 added a commit that referenced this issue Feb 8, 2025
@i582
fix(type-inference): for ternary expression with null branch
37eb745 
Fixes #66
@i582 i582 mentioned this issue Feb 8, 2025
Merged
@i582 i582 closed this as completed in #141 Feb 8, 2025
@i582 i582 closed this as completed in c9b037c Feb 8, 2025
@anton-trunov
Copy link
Member

It's the job of the typechecker, please stop duplicating Tact's implementation

@i582
Copy link
Collaborator

i582 commented Feb 15, 2025

It's the job of the typechecker, please stop duplicating Tact's implementation

Type inference is the core of language server. Without type inference, features like autocompletion will not work properly for fields/methods

@anton-trunov
Copy link
Member

Type inference is the core of language server.

it's not

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@i582 i582

Labels
bug Something isn't working or doesn't seem right lsp: inlayHint `textDocument/` Inlay Hint Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(type-inference): for ternary expression with null branch tact-lang/tact-language-server
4 participants
@anton-trunov @i582 @novusnota @Shvandre