Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show more information for instructions in asm functions with configuration #91

Closed
i582 opened this issue Feb 6, 2025 · 1 comment · Fixed by #244
Closed

Show more information for instructions in asm functions with configuration #91

i582 opened this issue Feb 6, 2025 · 1 comment · Fixed by #244
Assignees
Labels
asm Tasks related to ASM support in Tact lsp: inlayHint `textDocument/` Inlay Hint Request
Milestone

Comments

@i582
Copy link
Collaborator

i582 commented Feb 6, 2025

No description provided.

@i582 i582 added the lsp: inlayHint `textDocument/` Inlay Hint Request label Feb 6, 2025
@i582 i582 self-assigned this Feb 6, 2025
@novusnota
Copy link
Member

novusnota commented Feb 7, 2025

Sometimes, the asm instructions are contextual based on their arguments:

s1 PUSH // pushes the value of the stack register 1 (i.e. second-to-top value) onto the stack
c1 PUSH // pushes the value of the control register 1 onto the stack

Currently, it's not easy to make such a distinction. However, with the fix for tact-lang/tree-sitter-tact#49 it will be possible — I'll add arguments to each tvm instruction :)

UPD: Here you go tact-lang/tree-sitter-tact@ed4df8e. I'll add highlighting queries soon, but the corpus tests are there and are parsing nicely — so you can use the new grammar.js already!

Image

There's a temporary discrepancy in the compiler parser and the Tree-sitter, which was done to better accomodate the LS and to start narrowing down the syntax of Fift for future transition to the syntax of Tact assembly (when it arrives).

@i582 i582 added the asm Tasks related to ASM support in Tact label Feb 8, 2025
@i582 i582 added this to the v0.2.0 milestone Feb 13, 2025
@i582 i582 closed this as completed in #244 Feb 15, 2025
@i582 i582 closed this as completed in 3b62982 Feb 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
asm Tasks related to ASM support in Tact lsp: inlayHint `textDocument/` Inlay Hint Request
Projects
None yet
2 participants