-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: Add tests for signatureHelp #253
Conversation
primitive Int; | ||
|
||
contract Foo { | ||
fun sum(a: Int, b: Int = 10, c: Int = 20): Int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tact doesn't support this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
fun configure(a: Int, b: Int, c: Int) | ||
|
||
======================================================================== | ||
Chained Function Calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call it signatureHelp.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Renamed
It's weird behavior on windows. It doesn't work for first request, but fine for the next. I tried adding timeouts before the signatureHelp request in VSCode, tried saving the file (it's even worse - better not to do that), but it didn't work. |
test(`Signature: ${testCase.name}`, async () => { | ||
const signature = await this.getSignature(testCase.input) | ||
console.log("signature") | ||
console.log(JSON.stringify(signature)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove debug statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course.
It was just to see why tests were failing CI on Windows. Already removed because the tests are fixed.
fun globalFunc(map: Map) | ||
|
||
======================================================================== | ||
Global function with String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But function takes Int
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added also for Int
🤖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Resolves #211
Summary: