Skip to content

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Apr 12, 2024

Closes #245
Closes #247

Additionally changed one line injest.config.js (from maxWorkers: 1 to maxWorkers: "50%") which gave 7-10s speedup to tests on my machine and should also perform well in CI.

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota requested a review from anton-trunov April 12, 2024 22:16
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Let's also allow trailing commas in struct declarations and disallow empty trait lists

@anton-trunov anton-trunov merged commit 9c741b2 into tact-lang:main Apr 13, 2024
@novusnota novusnota deleted the leftout-trailing-commas branch April 13, 2024 13:33
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow empty lists of inherited traits Support trailing commas for remaining comma-separated lists
2 participants