Skip to content

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented May 23, 2024

Closes #345 and as result resolves #339 and resolves #327

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone May 23, 2024
@Gusarich Gusarich requested a review from anton-trunov May 23, 2024 06:28
@Gusarich
Copy link
Member Author

I'm not sure if the .include(...) thing is acceptable for such error messages checks, but it works.

@anton-trunov anton-trunov self-assigned this May 24, 2024
@Gusarich Gusarich requested a review from anton-trunov May 27, 2024 10:57
@anton-trunov
Copy link
Member

Looks like there is a merge conflict

@Gusarich
Copy link
Member Author

Looks like I've messed up the PR a little bit because of the automatically suggested merging on Github ☹️

@anton-trunov
Copy link
Member

@Gusarich Any progress here?

@Gusarich
Copy link
Member Author

Gusarich commented Jun 6, 2024

@anton-trunov reverted incorrect merge commit and rebased this PR correctly.
Sorry for the delay!

@anton-trunov anton-trunov merged commit 6e1aa01 into tact-lang:main Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants