Skip to content

Fix tests on nightly #130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jul 9, 2018
Merged

Fix tests on nightly #130

merged 3 commits into from
Jul 9, 2018

Conversation

tafia
Copy link
Owner

@tafia tafia commented Jul 9, 2018

There is no commitment from the compiler regarding Debug outputs. As a result, testing against Debug values was not robust and we should have test against Display values only.

This PR changes all tests to use Display ({}) instead of Debug ((:?}) in all format patterns. It also clears the tests somehow.

For more info, see rust-lang/rust#51843

@tafia tafia merged commit 08e401d into master Jul 9, 2018
@tafia tafia deleted the fixtest branch July 9, 2018 07:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant