Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modernize all dates in the chat_message_join table #48

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Modernize all dates in the chat_message_join table #48

merged 1 commit into from
Jun 10, 2023

Conversation

tagatac
Copy link
Owner

@tagatac tagatac commented Jun 10, 2023

What is changing: If a date from the chat_message_join table is not already modernized, modernize it (multiply by 1B).

Why this change is being made: It is possible that some of the dates have been modernized, and others have not.

Related issue(s): Fixes #40

Follow-up changes needed: None

Is the change completely covered by unit tests? If not, why not?: Yes

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0c3ff7d) 98.42% compared to head (8875bd8) 98.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files           7        7           
  Lines         824      827    +3     
=======================================
+ Hits          811      814    +3     
  Misses         10       10           
  Partials        3        3           
Impacted Files Coverage Δ
chatdb/chatdb.go 98.44% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tagatac tagatac merged commit 8d4c995 into main Jun 10, 2023
@tagatac tagatac deleted the fix-40 branch June 10, 2023 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the case where message_date's have inconsistent formats within a chat
1 participant