Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a YAML loader that always uses unicode. #400

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Add a YAML loader that always uses unicode. #400

merged 1 commit into from
Jun 8, 2021

Conversation

tomprince
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #400 (81970b9) into main (9d5de91) will decrease coverage by 6.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   82.76%   76.63%   -6.13%     
==========================================
  Files          35       35              
  Lines        2750     2761      +11     
  Branches      317      318       +1     
==========================================
- Hits         2276     2116     -160     
- Misses        393      580     +187     
+ Partials       81       65      -16     
Flag Coverage Δ
integration ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/magic_folder/util/encoding.py 87.50% <83.33%> (-12.50%) ⬇️
src/magic_folder/migrate.py 100.00% <100.00%> (ø)
src/magic_folder/watchdog/_watchdog_541.py 0.00% <0.00%> (-87.50%) ⬇️
src/magic_folder/watchdog/inotify.py 0.00% <0.00%> (-84.69%) ⬇️
src/magic_folder/__main__.py 0.00% <0.00%> (-80.00%) ⬇️
src/magic_folder/show_config.py 80.00% <0.00%> (-20.00%) ⬇️
src/magic_folder/cli.py 53.75% <0.00%> (-15.32%) ⬇️
src/magic_folder/util/fake_inotify.py 72.00% <0.00%> (-10.00%) ⬇️
src/magic_folder/magic_folder.py 80.35% <0.00%> (-1.79%) ⬇️
src/magic_folder/uploader.py 97.69% <0.00%> (-1.54%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5de91...81970b9. Read the comment docs.

@meejah
Copy link
Collaborator

meejah commented Jun 7, 2021

Could you please file a ticket explaining the motivation for this? We're only loading YAML from Tahoe, so at first it seems to me it'd be best to continue using "whatever Tahoe uses". (Does GridSync even need to use magic-folder migrate in the near term?)

@tomprince
Copy link
Contributor Author

Could you please file a ticket explaining the motivation for this?

I ran into this working on #369, migrate is sometimes passing bytes to GlobalConfigDatabase.create_magic_folder, which expects unicode. I could have just changed it to conditionally convert, but I also want to use yaml for jsonschema.

@tomprince
Copy link
Contributor Author

Does GridSync even need to use magic-folder migrate in the near term?

I'd be happy to tear out the migration support for now, instead.

@meejah
Copy link
Collaborator

meejah commented Jun 7, 2021

I don't think we should tear out the support; I just meant to note that we don't need to fix this now if there's no immediate need from GridSync.

@tomprince tomprince marked this pull request as ready for review June 8, 2021 18:54
@tomprince tomprince merged commit 85bdcd6 into tahoe-lafs:main Jun 8, 2021
@tomprince tomprince deleted the yaml-unicode branch June 8, 2021 18:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants