Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove partial support for migration from tahoe-lafs magic-folder. #402

Closed
wants to merge 1 commit into from
Closed

Remove partial support for migration from tahoe-lafs magic-folder. #402

wants to merge 1 commit into from

Conversation

tomprince
Copy link
Contributor

Fixes #401.

@tomprince tomprince requested a review from meejah June 7, 2021 19:32
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #402 (897a375) into main (31531e4) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   85.43%   85.61%   +0.18%     
==========================================
  Files          35       34       -1     
  Lines        2753     2712      -41     
  Branches      317      308       -9     
==========================================
- Hits         2352     2322      -30     
+ Misses        321      315       -6     
+ Partials       80       75       -5     
Flag Coverage Δ
integration 44.24% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/magic_folder/cli.py 73.13% <ø> (+2.56%) ⬆️
src/magic_folder/config.py 96.16% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31531e4...897a375. Read the comment docs.

Copy link
Collaborator

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the motivation for removing a feature that works; see #401 for that discussion though.

@tomprince tomprince closed this Jun 14, 2021
@tomprince tomprince deleted the remove-migrate branch June 23, 2021 18:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for migrating from tahoe-lafs magic folders.
2 participants