Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the reporting of integration tests. #483

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Improve the reporting of integration tests. #483

merged 4 commits into from
Jul 12, 2021

Conversation

tomprince
Copy link
Contributor

Fixes #482.

  • Capture coverage information from all integration tests, instead of just macOS.
  • Capture eliot logs from integration tests.
  • Turn on windows integration tests. (When I first enabled windows tests in CI, the integration tests seemed to be timing out; that is no longer the case).

I've found myself needing to add these changes to branches to debug things from CI, or re-run the tests locally.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #483 (b20f73e) into main (b9845af) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   91.46%   91.49%   +0.03%     
==========================================
  Files          35       35              
  Lines        2963     2963              
  Branches      339      339              
==========================================
+ Hits         2710     2711       +1     
+ Misses        181      180       -1     
  Partials       72       72              
Flag Coverage Δ
integration 70.73% <ø> (+0.06%) ⬆️
unit-test 87.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/magic_folder/downloader.py 96.50% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9845af...b20f73e. Read the comment docs.

@tomprince tomprince marked this pull request as ready for review July 12, 2021 19:07
@meejah meejah merged commit 13a2879 into tahoe-lafs:main Jul 12, 2021
@tomprince tomprince deleted the integration-reporting branch July 12, 2021 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture coverage and eliot logs from intergration tests.
2 participants