Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

543.connected enough #634

Merged
merged 15 commits into from
Feb 14, 2022
Merged

543.connected enough #634

merged 15 commits into from
Feb 14, 2022

Conversation

meejah
Copy link
Collaborator

@meejah meejah commented Feb 9, 2022

See also #543

This re-works how the "connected-enough" check works: instead of once, at startup it is monitored continuously. This is reflected in the "status" endpoint as well as affecting the behavior of our tahoe client (namely: it refuses to do mutable things if we're in a "degraded" state where less than a "happy" number of servers are connected).

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #634 (ad57d20) into main (a3d2986) will increase coverage by 0.30%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   92.09%   92.39%   +0.30%     
==========================================
  Files          38       38              
  Lines        4112     4171      +59     
  Branches      545      551       +6     
==========================================
+ Hits         3787     3854      +67     
+ Misses        221      215       -6     
+ Partials      104      102       -2     
Flag Coverage Δ
integration 75.04% <80.85%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/magic_folder/tahoe_client.py 93.83% <87.50%> (-0.83%) ⬇️
src/magic_folder/magic_file.py 96.46% <100.00%> (+0.45%) ⬆️
src/magic_folder/participants.py 91.75% <100.00%> (ø)
src/magic_folder/service.py 99.42% <100.00%> (+4.71%) ⬆️
src/magic_folder/status.py 94.93% <100.00%> (+1.18%) ⬆️
src/magic_folder/web.py 97.84% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d2986...ad57d20. Read the comment docs.

@meejah meejah merged commit e76bde7 into tahoe-lafs:main Feb 14, 2022
@meejah meejah deleted the 543.connected-enough branch February 14, 2022 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant