Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(protocol): encode basefee params into extraData #17860

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 29, 2024

This will avoid introducing those two params into Ethereum's block data structure which will cause block hash calculation different from Ethereum's.

@dantaik dantaik marked this pull request as ready for review July 29, 2024 03:03
@dantaik dantaik changed the title feat(protocol): encode basefee params into extraData's top 16bits feat(protocol): encode basefee params into extraData Jul 29, 2024
Copy link

openzeppelin-code bot commented Jul 29, 2024

feat(protocol): encode basefee params into extraData's top 16bits

Generated at commit: 91b80661a8c88d5117991d7fec07d3afa2a25818

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@davidtaikocha davidtaikocha merged commit 28681c0 into classic-1559 Jul 29, 2024
5 checks passed
@davidtaikocha davidtaikocha deleted the classic-1559-avoid-new-block-params branch July 29, 2024 04:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants