Add tags patroni fix #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghoneycutt could you or any authorised collaborator have a look? I would like to move things forward. If there is something else I should do, please tell me. |
ghoneycutt
reviewed
Dec 3, 2024
| @@ -328,6 +328,15 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'tags => true' do | |||
There was a problem hiding this comment.
There should be tests for all potential changes here.
What if
tags = true and tags_parameters is empty?
tags = true and tags_parameters has values?
tags = false and tags_parameters is empty?
tags = false and tags_parameters has values?
ghoneycutt
reviewed
Dec 3, 2024
| @@ -239,6 +239,10 @@ | |||
| # @param service_enable | |||
| # Patroni service enable property | |||
| # @param custom_pip_provider | |||
| # @param tags | |||
There was a problem hiding this comment.
Please add an acceptance test that shows when this is set to true and has tags_parameters that the correct information is in the yaml config.
|
Thank you very much for these contributions! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in our previous collaborator work.
-Fixed space.
-Removed expected tags parameters.
Im using patroni managed by puppet so I would like to move forward this change.
If there is something alse I should do, please tell me.