collecting GCP clusters data

[AnnuCode]

Problem

Collect GCP Container clusters data

Solution

Created container package to collect GCP container clusters data.

Changes Made

• created container package.
• transferred the ExtractZoneFromURL function to utils package in region.go file as it is also used in the compute package.

Notes

• Link of the GKE needs to be added in the models.Resource slice.
• Nodeconfig is used which is deprecated according to the docs. It can be replaced using Nodepool.

Checklist

• Code follows the contributing guidelines
• Any dependencies have been added to the project, if necessary

Reviewers

@eneskaya

[mlabouardy]

@AnnuCode do you need some help for the PR to be ready for review? :)

[AnnuCode]

@mlabouardy Hi, Link of the GKE needs to be added in the models.Resource slice but I do not know the correct format of the link.

[eneskaya]

one more remark, if it's deprecated to use NodeConfig, can you change this to the non-deprecated way?

[AnnuCode]

@eneskaya yes sure, working on it.

[eneskaya]

Hey @AnnuCode I wanted to test your code, but it seems there is a critical bug which leads to komiser crashing. Please see screenshot. You can ping me once the issue is resolved and I can have a look again.

EDIT: Also, make sure to add your container.Clusters in gcp.go, like so:

func listOfSupportedServices() []providers.FetchDataFunction {
	return []providers.FetchDataFunction{
		compute.Instances,
		storage.Buckets,
                container.Clusters // <--- Add this
	}
}

[mlabouardy]

Hey @AnnuCode, do you need some help with this PR? :)

[AnnuCode]

HI @mlabouardy , I think the program was crashing(invalid memory address) because I forgot to write the return statement in the error check associated with NodePool which is being shown in the attached photo above('failed to collect labels'). The issue is after I have written the return statement in the error check, I am not able to check if its the right fix as I am getting 'Network Request Error' after running go build and ./komiser start on my feature/666 branch. Is it because of the lack of cloud credentials in my case? The program is not crashing anymore with the above shown error but maybe I am not able to reproduce it properly?

[mlabouardy]

HI @mlabouardy , I think the program was crashing(invalid memory address) because I forgot to write the return statement in the error check associated with NodePool which is being shown in the attached photo above('failed to collect labels'). The issue is after I have written the return statement in the error check, I am not able to check if its the right fix as I am getting 'Network Request Error' after running go build and ./komiser start on my feature/666 branch. Is it because of the lack of cloud credentials in my case? The program is not crashing anymore with the above shown error but maybe I am not able to reproduce it properly?

the 'Network Request Error' error was fixed last week, if you rebase your branch with develop (make sure you pull latest changes from develop first) you won't have the issue anymore :)

[AnnuCode]

@mlabouardy Tried but could not do it. I started with git fetch upstream --> git merge upstream/develop from the feature branch --> git rebase upstream/develop from the feature branch. After resolving conflicts and doing git rebase --continue VSCode says failed to execute git. Also created a mess in this branch in the process.

[AnnuCode]

@mlabouardy @eneskaya After resolving conflicts in the rebase process, this message is there. Can you please have a look?

[mlabouardy]

@AnnuCode I've fixed the missing dependencies, thanks