Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add hidden attribute to internal <Hidden /> component when the Features.Hidden feature is used #2955

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add hidden attribute to internal <Hidden /> component when the Features.Hidden feature is used #2955

merged 2 commits into from
Jan 31, 2024

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Jan 31, 2024 •
edited
Loading

This PR adds the hidden attribute to the <Hidden /> component if the Features.Hidden is used as a feature.

We used to only add display: none, but that's not enough since certain CSS selectors still "see" this DOM node.

E.g.: space-x-4 in Tailwind CSS will set the margin-left on everything but the first DOM node. It is implemented with an exception for the hidden attribute.

Fixes: #2947

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 0:20am
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 0:20am

@RobinMalfait RobinMalfait merged commit edbcb81 into main Jan 31, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-2947 branch January 31, 2024 12:29
@RobinMalfait RobinMalfait mentioned this pull request Jan 31, 2024
Closed
RobinMalfait added a commit that referenced this pull request Apr 15, 2024
@RobinMalfait
Add hidden attribute to internal <Hidden /> component when the `F…
04695b2 
…eatures.Hidden` feature is used (#2955)

* add `hidden` attribute for `<Hidden features={Features.Hidden}>`

* update changelog
This was referenced May 18, 2024
Closed
Closed
Closed
@michael-moussaoui michael-moussaoui mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Closed
Closed
Closed
@ishaan-jaff ishaan-jaff mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@philpotisk philpotisk mentioned this pull request May 25, 2024
Closed
@Jeb4dev Jeb4dev mentioned this pull request May 25, 2024
Closed
@ha404 ha404 mentioned this pull request May 25, 2024
Open
This was referenced May 26, 2024
Closed
Closed
@gr00nd gr00nd mentioned this pull request May 28, 2024
Open
This was referenced May 28, 2024
Closed
Closed
@gr00nd gr00nd mentioned this pull request May 29, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 30, 2024
Closed
This was referenced May 31, 2024
Closed
Open
@philpotisk philpotisk mentioned this pull request Jun 2, 2024
Closed
@Jeb4dev Jeb4dev mentioned this pull request Jun 2, 2024
Open
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 5, 2024
Open
@iamsatyanchal iamsatyanchal mentioned this pull request Jun 5, 2024
Open
@thierry-laval thierry-laval mentioned this pull request Jun 6, 2024
Open
@gr00nd gr00nd mentioned this pull request Jun 15, 2024
Open
This was referenced Jun 18, 2024
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog] Visually hidden element without hidden attribute
1 participant
@RobinMalfait