Minimize 'locatePom()'-calls in PolyglotModelManager #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some Mapping implementations calling 'locatePom()' can be a relatively expensive operation, for example because it includes many file-system interactions. Because only the result of the mapping with the highest priority is returned eventually, 'findPom()' and 'determineFlavourFromPom()' can be speed-up if Mappings are processed in descending priority-order and simply return the first encountered result. Just like the get*() methods do.
|
@jvanzyl can you please have a look at this PR? |
|
Thank you @fbricon do you know of any plans about the next release that contains this change? |
|
@HannesWell I just made a release, should be in Maven Central shortly. |
|
Great! Thank you. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some Mapping implementations calling
locatePom()can be a relatively expensive operation, for example because it includes many file-system interactions.Because only the result of the mapping with the highest priority is returned eventually,
findPom()anddetermineFlavourFromPom()can be speed-up if Mappings are processed in descending priority-order and simply return the first encountered result. Just like the other get*() methods do.Additionally this PR simplifies the implementation of
getSortedMappings()at bit.