Added connection Handle check before gap event is handled in characteristic to fix the deadlock issue in #151 #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle_gap_event that lead to deadlocks where an invalid connection handle 65535 would occur after a failed notify ( no clue what caused that to occur).
The connection handle value was 65535(highest value for u16) which is an invalid conn_handle (unless someone somehow managed to connect that many devices).
The
try_lock()
worked as a stop gap but it would lead to failed read/write attempts when notify was in progress which would lead to disconnection.