Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(datastore): Support plain old list arg with IN filter #835

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(datastore): Support plain old list arg with IN filter #835

merged 1 commit into from
Dec 17, 2024

Conversation

onurdialpad
Copy link
Contributor

Summary

This PR adds support to IN filters with plain old list such as
query.filter('names IN', ['aaa', 'bbb'])

@onurdialpad onurdialpad requested review from TheKevJames, cphoward and a team as code owners December 3, 2024 00:23
@onurdialpad onurdialpad requested review from olidp and removed request for a team December 3, 2024 00:23
TheKevJames
TheKevJames approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already supported via the Array type, eg. since we generally try to match with the Google builtin types.

That said, I don't see any particular reason we couldn't support this syntactic sugar, sure thing.

@TheKevJames TheKevJames merged commit 7c8e7b7 into talkiq:master Dec 17, 2024
73 of 85 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TheKevJames TheKevJames TheKevJames approved these changes

@cphoward cphoward Awaiting requested review from cphoward cphoward is a code owner

@olidp olidp Awaiting requested review from olidp olidp is a code owner automatically assigned from talkiq/engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurdialpad @TheKevJames