Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

avoid latch #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid latch #86

wants to merge 1 commit into from

Conversation

RuihongY
Copy link
Collaborator

@RuihongY RuihongY commented Mar 1, 2025

No description provided.

Copy link
Owner

@tancheng tancheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test is due to flaky, shouldn't be a big problem.

@@ -131,6 +131,11 @@ def construct(s, NocPktType, DataType, data_mem_size_global,

@update
def assemble_xbar_pkt():
for i in range(num_xbar_in_rd_ports):
s.rd_pkt[i] @= TileSramXbarRdPktType(0,0,0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(0,0,0) - (0, 0, 0)

for i in range(num_xbar_in_rd_ports):
s.rd_pkt[i] @= TileSramXbarRdPktType(0,0,0)
for i in range(num_xbar_in_wr_ports):
s.wr_pkt[i] @= TileSramXbarWrPktType(0,0,0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@tancheng
Copy link
Owner

tancheng commented Mar 5, 2025

Still wanna submit this PR @RuihongY?

@RuihongY
Copy link
Collaborator Author

RuihongY commented Mar 6, 2025

Still wanna submit this PR @RuihongY?

will do it after finish layout

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants