Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the starting notification to use helper.echo from denops_std and make it optionally #19

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

peacock0803sz
Copy link
Contributor

@peacock0803sz peacock0803sz commented Nov 11, 2024

Motivation and Context

The current implementation uses console.log with default Deno.serve to show server startup notifications.
This results in red-colored output (tested in light-based terminals), and doesn't align well with denops's best practices.

What Changed

  1. Changed the server startup notification to use helper.echo from denops_std instead of Deno.serve's default logging
  2. Added a new option g:glance#server_silent that allows users to:
    • Completely suppress the startup notification when set to true
    • Maintain the default notification behavior when set to false (or not set)

Demo Videos

Current Behavior

vim-glance-asis.mp4

Default Behavior with this PR

vim-glance-noslient.mp4

Completely Silenced

vim-glance-slient.mp4

I hope this PR makes vim-glance more gently (for your eyes 😆 )

@peacock0803sz peacock0803sz changed the title chore: Improve starting notifications using helper.echo from denops_std and make optionally Improve starting notifications using helper.echo from denops_std and make optionally Nov 11, 2024
@peacock0803sz
Copy link
Contributor Author

peacock0803sz commented Nov 11, 2024

TODOs

  • Update description for this PR
  • Add demo screenshots

@peacock0803sz peacock0803sz changed the title Improve starting notifications using helper.echo from denops_std and make optionally Improve the starting notification to use helper.echo from denops_std and make it optionally Nov 11, 2024
@peacock0803sz peacock0803sz marked this pull request as ready for review November 21, 2024 10:19
@tani
Copy link
Owner

tani commented Nov 21, 2024

Thank you so much!

@tani tani merged commit 4da65c4 into tani:master Nov 21, 2024
@peacock0803sz peacock0803sz deleted the chore/starting-notify branch November 21, 2024 10:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants