Reverted the changes in SDL CMakeLists.txt and added a workaround where

we include the library
tanis2000 · Jan 29, 2025 · 9bcd42b · 9bcd42b
1 parent 8f07688
commit 9bcd42b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/deps/CMakeLists.txt b/src/deps/CMakeLists.txt
@@ -13,6 +13,8 @@ add_subdirectory(wren)
 set(SDL_STATIC ON)
 set(SDL_CAMERA OFF)
 set(SDL_VULKAN OFF)
+# Workaround for https://github.com/libsdl-org/SDL/issues/12078
+set(CMAKE_DISABLE_PRECOMPILE_HEADERS ON)
 add_subdirectory(sdl EXCLUDE_FROM_ALL)
 
 if (NOT EMSCRIPTEN)

diff --git a/src/deps/sdl/CMakeLists.txt b/src/deps/sdl/CMakeLists.txt
@@ -3451,7 +3451,7 @@ if(SDL_SHARED)
   set_property(TARGET SDL3-shared APPEND PROPERTY COMPATIBLE_INTERFACE_STRING "SDL_VERSION")
   set_property(TARGET SDL3-shared PROPERTY INTERFACE_SDL_VERSION "SDL${SDL3_VERSION_MAJOR}")
   if(NOT CMAKE_VERSION VERSION_LESS "3.16")
-#    target_precompile_headers(SDL3-shared PRIVATE "$<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:${PROJECT_SOURCE_DIR}/src/SDL_internal.h>")
+    target_precompile_headers(SDL3-shared PRIVATE "$<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:${PROJECT_SOURCE_DIR}/src/SDL_internal.h>")
   endif()
 endif()
 
@@ -3475,7 +3475,7 @@ if(SDL_STATIC)
   set_property(TARGET SDL3-static APPEND PROPERTY COMPATIBLE_INTERFACE_STRING "SDL_VERSION")
   set_property(TARGET SDL3-static PROPERTY INTERFACE_SDL_VERSION "SDL${SDL3_VERSION_MAJOR}")
   if(NOT CMAKE_VERSION VERSION_LESS "3.16")
-#    target_precompile_headers(SDL3-static PRIVATE "$<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:${PROJECT_SOURCE_DIR}/src/SDL_internal.h>")
+    target_precompile_headers(SDL3-static PRIVATE "$<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:${PROJECT_SOURCE_DIR}/src/SDL_internal.h>")
   endif()
 endif()